Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add empty state and loading state to Users & User Groups #1707

Merged
merged 1 commit into from
Nov 15, 2024

Conversation

radekkaluzik
Copy link
Contributor

Description

Implemented empty state and loading state to Users & User Groups

Links to mocks for empty state provided by UX:

RHCLOUD-34816


Screenshots

Loading state:

loading.state.mov

Empty state:

empty state users
empty state user group


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@radekkaluzik radekkaluzik requested a review from a team as a code owner November 14, 2024 16:38
@fhlavac
Copy link
Contributor

fhlavac commented Nov 15, 2024

@radekkaluzik I think we should use Skeleton table for the loading state https://www.patternfly.org/component-groups/status-and-state-indicators/skeleton-table, or did you agree on something different with UX?

@radekkaluzik
Copy link
Contributor Author

@radekkaluzik I think we should use Skeleton table for the loading state https://www.patternfly.org/component-groups/status-and-state-indicators/skeleton-table, or did you agree on something different with UX?

I didn't have any mocks for loading state so I have implemented some general loading state. I was told by UX this is ok, however I agree that Skeleton table would we more appropriate in this case.

@radekkaluzik
Copy link
Contributor Author

Updated Loading State here:
@fhlavac @karelhala

Updated.Loading.State.mov

@karelhala karelhala merged commit 92ea430 into RedHatInsights:master Nov 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants