Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RolesTable): add bulk Delete Roles button #1712

Merged
merged 5 commits into from
Nov 20, 2024

Conversation

InsaneZein
Copy link
Contributor

@InsaneZein InsaneZein commented Nov 19, 2024

Description

Finishes up RHCLOUD-32241 by allowing the user to delete multiple roles at once if multiple rows are selected, and also fixes the bulk select issue in the Roles table.


Screenshots

Screenshot from 2024-11-19 14-33-14


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@InsaneZein InsaneZein requested a review from a team as a code owner November 19, 2024 20:33
@codecov-commenter
Copy link

codecov-commenter commented Nov 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 17 lines in your changes missing coverage. Please review.

Project coverage is 43.07%. Comparing base (6c4cd82) to head (2a720b3).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
src/smart-components/role/RolesTable.tsx 0.00% 17 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1712      +/-   ##
==========================================
- Coverage   43.14%   43.07%   -0.07%     
==========================================
  Files         191      191              
  Lines        5273     5281       +8     
  Branches     1452     1455       +3     
==========================================
  Hits         2275     2275              
- Misses       2772     2780       +8     
  Partials      226      226              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@InsaneZein
Copy link
Contributor Author

/retest

@InsaneZein
Copy link
Contributor Author

9 snapshots failed from 4 test suites. Inspect your code changes or run npm test -- -u to update them.

I've updated the snapshots already, but it still says this. All the tests pass locally.

handleModalToggle(roles.filter((role) => selected.some((selectedRow: DataViewTrObject) => selectedRow.id === role.uuid)));
}}
>
Delete Roles
Copy link
Contributor

@fhlavac fhlavac Nov 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one should be localized

@fhlavac
Copy link
Contributor

fhlavac commented Nov 20, 2024

I've updated the snapshots already, but it still says this. All the tests pass locally.

@InsaneZein do you have the latest dependencies installed? It may cause the difference. I would try reinstalling them and updating snapshots again if necessary.

Otherwise, it looks good!

@InsaneZein
Copy link
Contributor Author

@fhlavac that worked. Thanks!

@InsaneZein InsaneZein merged commit 53f6670 into master Nov 20, 2024
11 checks passed
@InsaneZein InsaneZein deleted the delete-multiple-roles branch November 20, 2024 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants