-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RolesTable): add bulk Delete Roles button #1712
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1712 +/- ##
==========================================
- Coverage 43.14% 43.07% -0.07%
==========================================
Files 191 191
Lines 5273 5281 +8
Branches 1452 1455 +3
==========================================
Hits 2275 2275
- Misses 2772 2780 +8
Partials 226 226 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
/retest |
I've updated the snapshots already, but it still says this. All the tests pass locally. |
handleModalToggle(roles.filter((role) => selected.some((selectedRow: DataViewTrObject) => selectedRow.id === role.uuid))); | ||
}} | ||
> | ||
Delete Roles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This one should be localized
@InsaneZein do you have the latest dependencies installed? It may cause the difference. I would try reinstalling them and updating snapshots again if necessary. Otherwise, it looks good! |
@fhlavac that worked. Thanks! |
Description
Finishes up RHCLOUD-32241 by allowing the user to delete multiple roles at once if multiple rows are selected, and also fixes the bulk select issue in the Roles table.
Screenshots
Checklist ☑️