Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(RolesTable): add sorting and filtering #1728

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

InsaneZein
Copy link
Contributor

Description

Adds sorting and filtering to Roles table

RHCLOUD-34818


Screenshots

Screencast.from.2024-11-25.16-09-05.mp4

Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@InsaneZein InsaneZein requested a review from a team as a code owner December 12, 2024 16:05
@codecov-commenter
Copy link

codecov-commenter commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes missing coverage. Please review.

Project coverage is 41.35%. Comparing base (2db2f2f) to head (0832973).

Files with missing lines Patch % Lines
src/smart-components/role/RolesTable.tsx 0.00% 26 Missing ⚠️
...t-components/access-management/UserGroupsTable.tsx 0.00% 5 Missing ⚠️
.../smart-components/access-management/UsersTable.tsx 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1728      +/-   ##
==========================================
- Coverage   41.52%   41.35%   -0.17%     
==========================================
  Files         199      199              
  Lines        5491     5513      +22     
  Branches     1456     1458       +2     
==========================================
  Hits         2280     2280              
- Misses       2992     3014      +22     
  Partials      219      219              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@InsaneZein
Copy link
Contributor Author

/retest

1 similar comment
@fhlavac
Copy link
Contributor

fhlavac commented Dec 13, 2024

/retest

@InsaneZein InsaneZein force-pushed the roles-sorting-filtering2 branch from 14f5e7f to 9c7ef67 Compare December 17, 2024 14:04
@InsaneZein
Copy link
Contributor Author

/retest

Comment on lines 258 to 259
title="Name"
placeholder="Filter by name"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These should be localized

Copy link
Contributor

@fhlavac fhlavac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

@InsaneZein
Copy link
Contributor Author

/retest

@InsaneZein
Copy link
Contributor Author

Travis is having issues with uploading reports.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants