-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(RolesTable): add sorting and filtering #1728
base: master
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1728 +/- ##
==========================================
- Coverage 41.52% 41.35% -0.17%
==========================================
Files 199 199
Lines 5491 5513 +22
Branches 1456 1458 +2
==========================================
Hits 2280 2280
- Misses 2992 3014 +22
Partials 219 219 ☔ View full report in Codecov by Sentry. |
/retest |
1 similar comment
/retest |
14f5e7f
to
9c7ef67
Compare
/retest |
title="Name" | ||
placeholder="Filter by name" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These should be localized
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! 🎉
/retest |
Description
Adds sorting and filtering to Roles table
RHCLOUD-34818
Screenshots
Screencast.from.2024-11-25.16-09-05.mp4
Checklist ☑️