Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create edit user group page #1732

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

CodyWMitchell
Copy link
Contributor

Description

Created the Edit User Group page

  • I can edit an existing user group by performing any or all of the following actions:
  • I can rename the user group.
  • I can update the description of the user group.
  • I am notified if the updated user group name has already been used for my organization.
  • I can confirm or cancel the request.
  • Upon cancellation, I am redirected to the previous page/task.
  • Upon saving, I am presented with a success message and redirected to the User Group list.
  • I am presented with an error message if the user group is not saved successfully.

Will be handled in future ticket

  • I can add or remove principal users and service accounts from the user group from their respective tabs.

Currently values are diffed and displayed, then logged to the console. Another ticket will handle sending out the appropriate requests.

RHCLOUD-32236


Screenshots

After:

image


Checklist ☑️

  • PR only fixes one issue or story
  • Change reviewed for extraneous code
  • UI best practices adhered to
  • Commits squashed and meaningfully named
  • All PR checks pass locally (build, lint, test, E2E)

  • (Optional) QE: Needs QE attention (OUIA changed, perceived impact to tests, no test coverage)
  • (Optional) QE: Has been mentioned
  • (Optional) UX: Needs UX attention (end user UX modified, missing designs)
  • (Optional) UX: Has been mentioned

@CodyWMitchell CodyWMitchell requested a review from a team as a code owner December 13, 2024 15:33
@CodyWMitchell CodyWMitchell mentioned this pull request Dec 13, 2024
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant