Closes #174: GitHub button #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
castastrophe
reviewed
Feb 8, 2021
| @@ -1,4 +1,14 @@ | |||
| <section class="hero--component"> | |||
| <div> | |||
| <a href="{{$ctrl.hero.githubRepo}}" target="_blank" class="github-corner" aria-label="Fork me!"> | |||
| <svg width="80" height="80" viewBox="0 0 250 250" class="github-button" aria-hidden="true"> | |||
There was a problem hiding this comment.
While this is very cute, it does violate the GitHub brand guidelines: https://github.com/logos
|
I'm going to close this PR in the meantime as the design, unfortunately, violates the brand guidelines for GitHub. I also think the stakeholders need to decide if they want the website's GitHub link to be featured in this way since the goal of the page in my view, it to emphasize the developer's projects, not the site itself. I could see maybe including a link in the footer of the page. Let's chat more in the issue and see if there's a good middle-ground! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
I found this awesome GitHub corner that waves on hover, and thought it'd be cool to add it to the page to address issue #174. I'm by no means a designer so feel free to make any changes, I tried to follow the webpage design.
Browser requirements (for page updates)
Your updates should work in the following environments:
Ready-for-merge Checklist
Check off items as they are completed. Feel free to delete items if they are not applicable.