Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oobtkube should test other fields beyond .spec #228

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

oobtkube should test other fields beyond .spec #228

wants to merge 1 commit into from

Conversation

sfowl
Copy link
Collaborator

@sfowl sfowl commented Oct 21, 2024 •
edited
Loading

.spec is a common field in many but not all k8s objects. e.g. ConfigMap , Service Secret and Event do not have a .spec field. There are other fields worth testing, like .data in ConfigMap.

@sfowl sfowl requested a review from jeremychoi October 21, 2024 01:40
@sfowl sfowl self-assigned this Oct 21, 2024
jeremychoi
jeremychoi approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@jeremychoi jeremychoi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeremychoi jeremychoi jeremychoi approved these changes

Assignees

@sfowl sfowl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfowl @jeremychoi