This repository has been archived by the owner on Sep 12, 2023. It is now read-only.
allow spaces in Jenkins job names. [addresses #80] #99
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the fact that currently if there is a space in the Jenkins Job name, the scripts fail rather messily. (Issue #80)
To those that were at the RHTE Satellite hackathon and would like to contribute: since this is quite invasive, I definitely need 1 review incl testing, ideally 2.
If no other testers or the PR is deemed to messy, we can fall back to testing (at the very start of the build process) if there is a space in the job name and if there is fail the build immediately.
To those that do test, these four cases should be tested at a minimum
Also, please use the config.xml from e3bdf98 when testing, or at least the … parts. That part is different from what we have in master today.
pcfe