Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

allow spaces in Jenkins job names. [addresses #80] #99

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

pcfe
Copy link
Collaborator

@pcfe pcfe commented Nov 2, 2017

This PR addresses the fact that currently if there is a space in the Jenkins Job name, the scripts fail rather messily. (Issue #80)

To those that were at the RHTE Satellite hackathon and would like to contribute: since this is quite invasive, I definitely need 1 review incl testing, ideally 2.

If no other testers or the PR is deemed to messy, we can fall back to testing (at the very start of the build process) if there is a space in the job name and if there is fail the build immediately.

To those that do test, these four cases should be tested at a minimum

  • a Job with space(s) in the name, starting with a clean workspace
  • same job name, but with a pre-existing workspace
  • a Job without any separator in the name, starting with a clean workspace (to ensure nothing that works today is broke broken by e3bdf98)
  • same job name, but with a pre-existing workspace

Also, please use the config.xml from e3bdf98 when testing, or at least the … parts. That part is different from what we have in master today.

pcfe

@pcfe
Copy link
Collaborator Author

pcfe commented Nov 2, 2017

Tested on my home setup with these jobs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants