Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FEATURES: Password Verification, Signature Formatting, Credential Testing against WWW-Authenticate realms #620

Open
wants to merge 21 commits into
base: master
Choose a base branch
from

Conversation

redsand
Copy link

@redsand redsand commented Jul 25, 2023

Hi,

This request contains several new features. Firstly we needed to make an attempt to validate the credentials provided, to further validate the results from the scan. This allows for more concrete actionable items for review and remediation. In order to do this, additional structure and formatting was required in the signatures.txt file. An additional credentials field has been added to the end, after the description field. Each entry is seperated by (username)/(password) and multiples can be added by separating them with a ';' such as: admin/admin;admin/123;user/456

Additionally, screenshots are captured to help validate default credential detection during review and has been included in the generated report.

Finally, a feature to detect remote hosts based upon the combination of Server and WWW-Authenticate headers. This is necessary for detecting and attempting default credentials from hosts that use WWW-Authenticate realms and has been tested against two remote hosts. Additional signatures and growth is required.

@ChrisTruncer
Copy link
Contributor

Thanks for an awesome and massive pull request. We'll get testing this on our end prior to merge. thank you!

@redsand
Copy link
Author

redsand commented Jul 26, 2023

Thanks for an awesome and massive pull request. We'll get testing this on our end prior to merge. thank you!

Hit me up with any questions. There's opportunity to improve the valid credential detection. Also noticed that the new screenshot file for authentication verification can be overwritten and needs to be checked/incremented. will sort this out now.

@digininja
Copy link
Contributor

I've not read through the code so this may already be in place, but it would be good if this was optional and disabled by default.

I think going from just taking a screenshot is a significant enough change that people won't be expecting it and in some rare cases it may cause people problems.

@ChrisTruncer
Copy link
Contributor

Just checking in, don't want you to think we forgot about this. We're all at BlackHat/Defcon this week and next so we're fairly tied up, but this is still on top of our list as to review and merge in.

Also, I do agree that we should ensure that the active checking is disabled by default, but can be enabled by a command line flag (if that's not how it is currently designed)

@redsand
Copy link
Author

redsand commented Aug 7, 2023

This feature is now disabled by default. To enable, use --enable-validation

@redsand
Copy link
Author

redsand commented Aug 8, 2023

Thanks everyone for the feedback. Request has been updated and am currently testing it internally with solid success. Have a great time in vegas, have a beer for me. <3

@redsand
Copy link
Author

redsand commented Sep 9, 2023

Bump

@redsand
Copy link
Author

redsand commented Sep 13, 2023

Any updates or feedback?

@ChrisTruncer
Copy link
Contributor

Sorry, this was not forgotten, this is just a giant merge in (with awesome functionality). Ideally Q1 is the best time for us to look to merge this.

@redsand
Copy link
Author

redsand commented Apr 23, 2024

Checking in on this.

@0x6d6f7468
Copy link
Collaborator

Hey @redsand, thanks for checking in. I imagine Chris is swamped right now.

Now that we finally have the setup script rewrite dealt with, @Relkci and I will be finding the time to go through this. I don't want to make promises we can't keep so I can't give you an exact timeline, but we've started looking through your changes and you can expect some feedback from us in the near future.

Thanks for your contribution and your patience. 😄

@Relkci
Copy link
Collaborator

Relkci commented Jun 14, 2024

updated to resolve conflicts

@Relkci Relkci added enhancement python Python codebase labels Jun 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement python Python codebase
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants