Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initial commit of dictionary support #169

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

initial commit of dictionary support #169

wants to merge 1 commit into from
+130 −0

Conversation

gkorland
Copy link
Contributor

No description provided.

@gkorland gkorland requested review from gavrie and oshadmi July 18, 2021 20:22
gavrie
gavrie reviewed Jul 20, 2021
View reviewed changes
Copy link
Contributor

@gavrie gavrie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkorland what's the point of using this dictionary interface in a Rust module? I understand it might be convenient when writing in C, but in Rust you can just use HashMap with the Redis allocator.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavrie gavrie gavrie left review comments

@oshadmi oshadmi Awaiting requested review from oshadmi

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gkorland @gavrie