Derive hash and comparison traits for RedisAlloc #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CircleCI doesn't support macos anymore (the way we defined the job). I suggest we just merge and fix the CI later. |
| @@ -22,7 +22,7 @@ const REDIS_ALLOCATOR_NOT_AVAILABLE_MESSAGE: &str = | |||
| /// Defines the Redis allocator. This allocator delegates the allocation | |||
| /// and deallocation tasks to the Redis server when available, otherwise | |||
| /// it panics. | |||
| #[derive(Default, Debug, Copy, Clone)] | |||
| #[derive(Default, Debug, Copy, Clone, PartialEq, Eq, PartialOrd, Ord, Hash)] | |||
There was a problem hiding this comment.
Why do you need to compare the allocator? Or hash it?
There was a problem hiding this comment.
I don't need it right here, but if the struct wants to wrap it within another struct and do some counting and simply wants to derive a trait, not having those for RedisAlloc disallows that and requires implementing it manually. This is more just for convenience.
MeirShpilraien
approved these changes
Jul 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadens the use of the
RedisAllocallocator by deriving more traits, so that the user can utilise theRedisAllocin more ways.