Add high level wrapper for RedisModule_EmitAOF #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavrie
suggested changes
May 21, 2020
| @@ -209,4 +209,9 @@ impl Context { | |||
| pub fn create_string(&self, s: &str) -> RedisString { | |||
| RedisString::create(self.ctx, s) | |||
| } | |||
|
|
|||
| #[cfg(feature = "experimental-api")] | |||
| pub fn emit_aof(&self, io: *mut raw::RedisModuleIO, command: &str, args: &[&str]) { | |||
There was a problem hiding this comment.
The public API of Context should not use raw pointers like *mut raw::RedisModuleIO; its whole purpose it to provide a safe abstraction over them.
I haven't dived deeply into this, but it seems the correct thing here is to create a wrapper struct around the raw type and pass safe Rust references to it (like Context itself).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #74