fix: hoist and combine allOf subschema titles #1977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What/Why/How?
Issues #932 and #1256 raise the point that the typically achieved rendering of the schemas resulting from nestend
oneOf
andallOf
are unexpectedly ugly, namelyobject
.In #932 (comment) the point is raised that simply using one of the titles of multiple
allOf
options (e.g. the first one) might be wrong as the other elements might also have added semantics.Hence this PR collects all schema titles from the subschemas below
allOf
(pulled down viahoistOneOf
or not) and combines them via+
for display. Schemas without title are not included, giving the API developer some flexibility to consider them for inclusion in display.Reference
Closes #932 (differently)
Closes #1256
Testing
Screenshots (optional)
Source:
Check yourself