-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove WorldEdit hard-dependency #212
Merged
Matthias1590
merged 13 commits into
RedstoneTools:dev
from
xtrm-en:fix/worldedit-dependency
Jun 19, 2023
Merged
Remove WorldEdit hard-dependency #212
Matthias1590
merged 13 commits into
RedstoneTools:dev
from
xtrm-en:fix/worldedit-dependency
Jun 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lectionUtils to except classloading, add worldedit dependency to some features
Matthias1590
requested changes
Jun 4, 2023
src/main/java/tools/redstone/redstonetools/features/Feature.java
Outdated
Show resolved
Hide resolved
Matthias1590
approved these changes
Jun 4, 2023
Matthias1590
added
pr/needs-testing
The funcitonality added needs to be tested
general/high-priority
This has high priority
labels
Jun 4, 2023
Dev artifacts cause a crash when I try to run without worldedit
|
Matthias1590
requested changes
Jun 6, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Crashes when worldedit isnt installed
Matthias1590
removed
the
pr/needs-testing
The funcitonality added needs to be tested
label
Jun 6, 2023
…ded DependencyLookup util class Co-authored-by: JayMensink
Matthias1590
requested changes
Jun 9, 2023
src/main/java/tools/redstone/redstonetools/mixin/gamerules/DoContainerDropsMixin.java
Outdated
Show resolved
Hide resolved
src/main/java/tools/redstone/redstonetools/utils/WorldEditUtils.java
Outdated
Show resolved
Hide resolved
# Conflicts: # src/main/java/tools/redstone/redstonetools/mixin/gamerules/DoContainerDropsMixin.java
Matthias1590
approved these changes
Jun 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #199