Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove WorldEdit hard-dependency #212

Merged
merged 13 commits into from
Jun 19, 2023
Merged

Remove WorldEdit hard-dependency #212

merged 13 commits into from
Jun 19, 2023

Conversation

xtrm-en
Copy link
Contributor

@xtrm-en xtrm-en commented Jun 3, 2023

Fixes #199

…lectionUtils to except classloading, add worldedit dependency to some features
@xtrm-en xtrm-en marked this pull request as draft June 3, 2023 23:03
@xtrm-en xtrm-en marked this pull request as ready for review June 3, 2023 23:06
@xtrm-en xtrm-en requested a review from Matthias1590 June 4, 2023 01:31
@Matthias1590 Matthias1590 added pr/needs-testing The funcitonality added needs to be tested general/high-priority This has high priority labels Jun 4, 2023
@Matthias1590 Matthias1590 self-assigned this Jun 6, 2023
@Matthias1590
Copy link
Member

Dev artifacts cause a crash when I try to run without worldedit

java.lang.RuntimeException: Could not execute entrypoint stage 'client' due to errors, provided by 'redstonetools'!
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
	at net.minecraft.class_310.<init>(class_310.java:452)
	at net.minecraft.client.main.Main.main(Main.java:197)
	at net.fabricmc.loader.impl.game.minecraft.MinecraftGameProvider.launch(MinecraftGameProvider.java:461)
	at net.fabricmc.loader.impl.launch.knot.Knot.launch(Knot.java:74)
	at net.fabricmc.loader.impl.launch.knot.KnotClient.main(KnotClient.java:23)
Caused by: java.lang.NoClassDefFoundError: com/sk89q/worldedit/IncompleteRegionException
	at tools.redstone.redstonetools.RedstoneToolsGameRules.register(RedstoneToolsGameRules.java:19)
	at tools.redstone.redstonetools.RedstoneToolsClient.onInitializeClient(RedstoneToolsClient.java:24)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:47)
	... 7 more
Caused by: java.lang.ClassNotFoundException: com.sk89q.worldedit.IncompleteRegionException
	at java.base/jdk.internal.loader.BuiltinClassLoader.loadClass(BuiltinClassLoader.java:641)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	at net.fabricmc.loader.impl.launch.knot.KnotClassDelegate.loadClass(KnotClassDelegate.java:226)
	at net.fabricmc.loader.impl.launch.knot.KnotClassLoader.loadClass(KnotClassLoader.java:145)
	at java.base/java.lang.ClassLoader.loadClass(ClassLoader.java:520)
	... 10 more


A detailed walkthrough of the error, its code path and all known details is as follows:
---------------------------------------------------------------------------------------

-- Head --
Thread: Render thread
Stacktrace:
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.lambda$invoke0$0(EntrypointUtils.java:51)
	at net.fabricmc.loader.impl.util.ExceptionUtil.gatherExceptions(ExceptionUtil.java:33)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke0(EntrypointUtils.java:49)
	at net.fabricmc.loader.impl.entrypoint.EntrypointUtils.invoke(EntrypointUtils.java:35)
	at net.fabricmc.loader.impl.game.minecraft.Hooks.startClient(Hooks.java:53)
	at net.minecraft.class_310.<init>(class_310.java:452)

Copy link
Member

@Matthias1590 Matthias1590 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Crashes when worldedit isnt installed

@Matthias1590 Matthias1590 removed the pr/needs-testing The funcitonality added needs to be tested label Jun 6, 2023
@xtrm-en xtrm-en requested a review from Matthias1590 June 9, 2023 17:39
@xtrm-en xtrm-en requested a review from Matthias1590 June 9, 2023 17:56
@Matthias1590 Matthias1590 merged commit b684f8e into RedstoneTools:dev Jun 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
general/high-priority This has high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants