-
Notifications
You must be signed in to change notification settings - Fork 260
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update app to run on Node 18 or newer (NodeJS 16 has reached End of Support) #682
Comments
Posting my notes from the commit message of 562e635 (from PR #678), in case it is helpful:
|
Hey @DeeDeeG I did some work on this one and from what I can tell, it looks like webpacker did release a version 6.0.0.rc, but the npm package |
On the topic of webpacker 6: I believe the closest thing is either the As for the git tag of I did try to upgrade to newer webpack + webpacker myself, but the configuration files and project setup for using Webpack are very unfamiliar to me, the docs weren't clear enough to me, and I got stuck somewhere through attempting this myself. Anyone more familiar with Webpack might have more success with this, hopefully. On the topic of Rails 7: Yes, if we can manage to upgrade to Rails 7 in all this, or even by itself without breaking anything else, that would be welcome in its own right. Last time we got to Rails 6, I was expecting it to require a large migration effort, but someone upgraded Rails 6 in-place over Rais 5 with essentially no further changes. (Here: 520e8c5 from #675.) (I have been nervous to attempt this myself, but perhaps it will "just work" updating Rails to version 7 in the |
It's possible we can "cheat" a bit, or use a workaround, by exporting the environment variable I can easily add it as an env var (and bump to newer NodeJS) in the Dockerfile in the root of this repo, to test that out with a newer NodeJS version. And then it would require one of the other maintainers' cooperation in order to set this env var in our Heroku environment as well, if this is something proven to work. I will take some time to test this today, as a quick/minimal approach with the goal of getting to Node 18. (I reviewed the issue thread webpack/webpack#14532 again recently, and from a comment in that thread, I noticed this suggested workaround. Not sure why I hadn't tried this earlier, other than the want to properly upgrade anyway making "workarounds" seem like the wrong approach at the time. But since NoeJS 16 support is over, now may be the time for whatever quickest/smallest fix is possible.) |
The workaround env var + bumping to NodeJS 18 (or 20) seems to be working. And I believe I can set the env var for production via the Heroku app configuration file Being stuck on unsupported NodeJS isn't great. I consider this part of my ongoing dependency bumps. |
See:
NodeJS 16 has reached End of Support as of 11th September 2023.
We should update some things to get the app running on newer NodeJS, which for still-supported versions would be Node 18 or newer.
I tried to do so during #678, but ran into issues with our older version of Webpack not working with Node 18, and it not being obvious to me personally how to properly migrate to newer Webpack either.
If anyone can help get the app running and functional (passing our CI tests, etc.), that would be much appreciated! I'm marking this issue as "Help Wanted" just in case it helps draw attention from some helpful folks to get us past this tech stack upgrade. Thanks in advance for any help with this.
Best Regards,
- DeeDeeG
The text was updated successfully, but these errors were encountered: