Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Webpack 5 and Upgrade Node.js to 20 #695

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mmx900
Copy link
Contributor

@mmx900 mmx900 commented Jun 7, 2024

Context

  • Fixes Update app to run on Node 18 or newer (NodeJS 16 has reached End of Support) #682
  • To update Node.js, this PR migrates the project from Webpacker to Webpack 5 using jsbundling-rails. Initially, I also tried Shakapacker, but it seemed to require more effort. Since I am not an expert in Webpack (I primarily use importmap-rails at work), I may not be aware of all the considerations. However, if there is a compelling reason to use Shakapacker, I am open to retrying the migration.
  • While tests are passing, we need to verify that the bundling works correctly on the production server and in other developers' dev environments.

Summary of Changes

Checklist

  • Tested Mobile Responsiveness
  • Added Unit Tests
  • CI Passes
  • Deploys to Heroku on test Correctly (Maintainers will handle)
  • Added Documentation (Service and Code when required)

Screenshots

Before

After

@DeeDeeG
Copy link
Contributor

DeeDeeG commented Jun 15, 2024

Sorry for the delayed response, I will be unavailable to test this until at least the 15th, possible a few days after.

I can spin this up in Docker and see how that goes, and ideally (pay for and run it in) a test Dyno on Heroku.

Thank you for the multiple contributions!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update app to run on Node 18 or newer (NodeJS 16 has reached End of Support)
2 participants