Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4 automatic schema registration retrieval #5

Merged
merged 2 commits into from
Aug 5, 2024

Conversation

stefan-cardnell-rh
Copy link
Contributor

@stefan-cardnell-rh stefan-cardnell-rh commented Aug 2, 2024

For Producing (serializing), Topic subclasses must return a schema from key_schema and value_schema, otherwise AvroSerializer will produce an error.

For Consuming (deserialzing), Topic subclasses can leave key_schema and value_schema returning None, and AvroDeserializer will fetch the right schema based on the message contents. Or they can optionally override it to use a different schema.

Also serializer_conf added as a parameter to Topic so serialization conf can be adjusted (e.g. adjusting subject.name.strategy).

@stefan-cardnell-rh stefan-cardnell-rh changed the title 4 automatic schema registration retrieval automatic schema registration retrieval Aug 2, 2024
@stefan-cardnell-rh stefan-cardnell-rh changed the title automatic schema registration retrieval 4 automatic schema registration retrieval Aug 2, 2024
@bodja
Copy link
Contributor

bodja commented Aug 5, 2024

@stefan-cardnell-rh we can deploy this one as a temporary solution. I'll work today to make it more flexible and strict.

django_kafka/topic.py Outdated Show resolved Hide resolved
@stefan-cardnell-rh stefan-cardnell-rh force-pushed the 4-automatic-schema-registration-retrieval branch from a6d2d52 to 3a1a560 Compare August 5, 2024 13:28
@stefan-cardnell-rh stefan-cardnell-rh merged commit 980e0ee into main Aug 5, 2024
17 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants