Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings + 2.4 BC break #8

Merged
merged 3 commits into from
Feb 5, 2015
Merged

Conversation

ThaDafinser
Copy link
Contributor

Badly my last PR contained an issue (my logging didnt worked correctly...):

WARNING RerUserDates[2015-02-04 15:45:07] [2471e] D:\htdocs\piwik\core\Plugin\Settings.php(95): Warning - array_key_exists(): The first argument should be either a string or an integer - Piwik 2.10.0 - Please report this message in the Piwik forums: http://forum.piwik.org (please do a search first as it might have been reported already)

Additionally i removed the 2.4 BC compability like ref in #7

tassoman added a commit that referenced this pull request Feb 5, 2015
@tassoman tassoman merged commit 387ff04 into RegioneER:master Feb 5, 2015
@tassoman
Copy link
Member

tassoman commented Feb 5, 2015

Thank you for this correction. It make me wonder if we need more tests 😁

@ThaDafinser
Copy link
Contributor Author

Yes...was my fault... 👍

My plan is also to integrate some unitTests in my pluings: https://developer.piwik.org/guides/tests-php

@tassoman
Copy link
Member

tassoman commented Feb 5, 2015

Yup, mine plan too! I've just opened #9 ✔️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants