Collabora default certificate type same as chosen by inventory variable #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we enter nextcloud_certificate_type variable at the inventory, the collabora cert should use the same variable for its cert. Otherwise, if you obtain acme cert for nextcloud, you still get selfsigned cert for collabora. Furthermore, for my installation I had to change this and also add the line "tls_certificate_test: false", but I can't seem to remember why right now, so I didn't include it in the PR, but it could be useful.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we enter nextcloud_certificate_type variable at the inventory, the collabora cert should use the same variable for its cert. Otherwise, if you obtain acme cert for nextcloud, you still get selfsigned cert for collabora.
Furthermore, for my installation I had to change this and also add the line "tls_certificate_test: false", but I can't seem to remember why right now, so I didn't include it in the PR, but it could be useful.