Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix censor comment causing negative discussion count #2061

Merged
merged 5 commits into from
Jan 6, 2025

Conversation

koutst
Copy link
Contributor

@koutst koutst commented Jan 6, 2025

  • We are double counting deletions. When a user is flagged as spam we delete all the comments they've made. If those comments are children of the other comments we were double decrementing the discussion count on deletion.

@koutst koutst requested a review from a team as a code owner January 6, 2025 15:08
Copy link

codecov bot commented Jan 6, 2025

Codecov Report

Attention: Patch coverage is 92.30769% with 1 line in your changes missing coverage. Please review.

Project coverage is 65.78%. Comparing base (a50a3fc) to head (d698311).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
src/researchhub_comment/views/rh_comment_view.py 92.30% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2061      +/-   ##
==========================================
+ Coverage   65.69%   65.78%   +0.08%     
==========================================
  Files         421      421              
  Lines       23810    23819       +9     
==========================================
+ Hits        15643    15670      +27     
+ Misses       8167     8149      -18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@koutst koutst changed the title Fix censor comment Fix censor comment causing negative discussion count Jan 6, 2025
Copy link

sonarqubecloud bot commented Jan 6, 2025

@koutst koutst merged commit 8a52747 into master Jan 6, 2025
4 checks passed
@koutst koutst deleted the fix-censor-comment branch January 6, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants