Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stacked bar graphs #120

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Ramshandilya
Copy link
Member

Overview

Add support for Stacked Bar Graphs

Actions

  • Implement APCBarGraphView
  • Refactor other Graph Views

Result

Pretty graphs
unnamed-1

@YuanZhu-apple
Copy link
Member

@Ramshandilya FYI. The charts library has been in ResearchKit.
Do you think you can make this compatible with RK charts library and post to RK?

@rsanchezsaez
Copy link

@Ramshandilya: I'll start porting this into ResearchKit soon. Let me know if you have any suggestions or comments.

@Ramshandilya
Copy link
Member Author

Hi there,
I'm on vacation. I can tackle this on monday.
@rsanchezsaez If you're willing to port this, please go ahead. The structure is very similar other charts. Feel free to reach me in case you run into issues.

@rsanchezsaez
Copy link

Hey @Ramshandilya, yeah it may be faster for me to do it, as I have the adapted chart code fresh in my mind. I'll start working on it soon, and let you know if I have any questions.

Thanks!

@rsanchezsaez
Copy link

@Ramshandilya: there's one thing you could do to help me with this. Could you upload a minimum AppCore-based example showing APCBarGraphView in action? Thanks!

@Ramshandilya
Copy link
Member Author

@rsanchezsaez I've put up a gist of the datasource implementation.
https://gist.github.com/Ramshandilya/4dd7ae8e500d1edb4266
Let me know if this is what you're looking for.

@rsanchezsaez
Copy link

@Ramshandilya That helps, but I was thinking if you could upload a minimal self-contained runnable project, to save me some time. If not, no worries, I think I'll be able to build one. :-)

Erin-Mounts added a commit to Erin-Mounts/AppCore that referenced this pull request Jun 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants