Replacing URLWithString: by fileURLWithPath: #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -238,7 +238,7 @@ - (UICollectionViewCell *)collectionView:(UICollectionView *)collectionView cell | |||
|
|
|||
| NSString *filePath = [[NSBundle mainBundle] pathForResource: studyDetails.detailText ofType:@"html" inDirectory:@"HTMLContent"]; | |||
| NSAssert(filePath, @"Expecting file \"%@.html\" to be present in the \"HTMLContent\" directory, but didn't find it", studyDetails.detailText); | |||
| NSURL *targetURL = [NSURL URLWithString:filePath]; | |||
There was a problem hiding this comment.
Missed stringByAddingPercentEscapesUsingEncoding:?
There was a problem hiding this comment.
@YuanZhu-apple This code is correct, if we use fileURLWithPath: we do not need to use stringByAddingPercentEscapesUsingEncoding :, only fileURLWithPath already does everything.
Erin-Mounts
added a commit
to Erin-Mounts/AppCore
that referenced
this pull request
Oct 18, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thus managed to avoid problems like build the URL with null values if the string contains spaces or special character.