raise exc if trying to set a dict with no id as prop value

rocrate/model/entity.py

@@ -102,6 +102,9 @@ def __setitem__(self, key: str, value):
         if key.startswith("@"):
             raise KeyError(f"cannot set '{key}'")
         values = value if isinstance(value, list) else [value]
+        for v in values:
+            if isinstance(v, dict) and "@id" not in v:
+                raise ValueError(f"no @id in {v}")
         ref_values = [{"@id": _.id} if isinstance(_, Entity) else _ for _ in values]
         self._jsonld[key] = ref_values if isinstance(value, list) else ref_values[0]
 

test/test_model.py

@@ -363,6 +363,11 @@ def test_entity_as_mapping(tmpdir, helpers):
     }
     crate_dir = tmpdir / "in_crate"
     crate_dir.mkdir()
+    with open(crate_dir / helpers.METADATA_FILE_NAME, "wt") as f:
+        json.dump(metadata, f, indent=4)
+    with pytest.raises(ValueError):
+        crate = ROCrate(crate_dir)
+    del metadata["@graph"][2]["badProp"]
     with open(crate_dir / helpers.METADATA_FILE_NAME, "wt") as f:
         json.dump(metadata, f, indent=4)
     crate = ROCrate(crate_dir)
@@ -411,6 +416,7 @@ def test_entity_as_mapping(tmpdir, helpers):
         "application/json",
         "https://www.json.org",
     }
+    correction._jsonld["badProp"] = {"k": "v"}
     with pytest.raises(ValueError):
         correction["badProp"]