Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set the encoding option of the open() functions in the codes #209

Merged
merged 9 commits into from
Dec 12, 2024

Conversation

Surpris
Copy link
Contributor

@Surpris Surpris commented Dec 11, 2024

Brief

This pull request is relevant to Issue #207:

What' changed

Set encoding='utf-8' options to the following functions/methods and take some refactoring:

  • read_metadata() in rocrate/metadata.py
  • write() in rocrate/mode/file.py
  • write() in rocrate/mode/metadata.py
  • write() in rocrate/mode/preview.py

Note

There are no unit-test functions for the Metadata class, etc. It might be desirable to add some.

@Surpris Surpris requested a review from simleo December 11, 2024 14:49
@Surpris Surpris changed the title Develop 207 Set the encoding option of the open() functions in the codes Dec 11, 2024
@simleo
Copy link
Collaborator

simleo commented Dec 12, 2024

@Surpris since you're a new contributor I need you to update the authors section in CITATION.cff. I also need your copyright line to update the headers.

@Surpris
Copy link
Contributor Author

Surpris commented Dec 12, 2024

@simleo,
Thank you for your request.
I tried to update CITATION.cff and the scripts that I had modified.
Please confirm whether the changes are what you expected.

@simleo simleo merged commit 458baa3 into ResearchObject:master Dec 12, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants