Tanstack react query v5 #122
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jonathonhawkins92
changed the title
DinerIsmail
force-pushed
the
tanstack-react-query-v5
branch
from
a917319 to
3d43412
Compare
DinerIsmail
approved these changes
Nov 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some resources I've used when working on this:
https://tanstack.com/query/v5/docs/react/guides/migrating-to-v5
https://tkdodo.eu/blog/breaking-react-querys-api-on-purpose
I've removed the explicit return type from the queries, and switched to passing the return value to the
useQuerygeneric instead.I also updated quite a bit of naming, they've changed the meaning of
isLoadingto be whatisInitialLoadingwas; which is now deprecated, and added a new state/flag calledisPending, this means that where before you aliased the variables asisLoading{Thingy}it's nowis{Thingy}Pendingwhich is more in line with your error aliasis{Thingy}Error, though tbh I think in my own projects I will stop destructuring these values so that I can doThingy.isPendingect.Note - due to the way to codemod works I've had to build this on top of the code quality branch so that I could format after running it.