-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZstdSerializer, change Key to include "domain" #58
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Love the domain concept - super simple.
Would it make sense to also allow different serializers for different domains? My hunch is no because it makes things very complicated (in particular, the application code now controls more details around compatiblity...).
We can definitely build a new serializer that routes serialization depending on domain, it can use composition to reuse existing ones. Serializing in |
Changes:
The idea is that domain can be used to mark keys as belonging to a use-case domain, and specify custom Zstd dictionaries for some domains. Also domains can be used to track per-domain counters (hits, hit ratio, etc), but this is not implemented yet.