-
Notifications
You must be signed in to change notification settings - Fork 328
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renable latest DocC #4240
base: main
Are you sure you want to change the base?
Renable latest DocC #4240
Conversation
This reverts commit 45e3620.
@RCGitBot please test |
there are a couple of fastlane lanes that you can use to generate the docs and preview them, |
look for this: https://revenuecat.github.io/purchases-ios-docs/5.0.0/documentation/revenuecat/purchases/offerings() the description should be the one for the method, not "inherited" (TIL the current version is broken) |
here's a non-broken version for comparison |
@jamesrb1 were you able to check? |
I'm unable to compile the docs on main and this branch because it's trying to use macOS instead of iOS. Trying to figure this out....
|
@aboedo I wasn't able to get it running locally using Xcode 15 and Xcode 14 (which the CI machine uses) won't run on Sonoma.... but I'm on my way to having the CI machine make the output available as an artifact, will finish this up tomorrow. |
@jamesrb1 I'm a bit confused as to why we need to take care of this now, was it blocking a release? |
It's not blocking a release, but when you asked about it, I thought I should take a look. Most of the time I spent on this was after hours. I'll set it aside for now! |
Converted back to draft as no longer in a mergable state - artifact output needs zipping and code needs tidying. |
DocC has fixed the issue, and this PR reverts our package files to use the plugin's latest version, as it was before.
Unsure if we need to check its output somehow, or how best to do that.