Moves miscellaneous types to the models package #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/MovedModels.kt
tonidero
approved these changes
Sep 12, 2024
vegaro
approved these changes
Sep 12, 2024
# Conflicts: # apiTester/src/commonMain/kotlin/com/revenuecat/purchases/kmp/apitester/PurchasesCommonAPI.kt # core/api/core.api # core/api/core.klib.api # core/src/androidMain/kotlin/com/revenuecat/purchases/kmp/Purchases.android.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/MovedModels.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/Purchases.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/PurchasesConfiguration.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/ktx/Coroutines.kt # core/src/iosMain/kotlin/com/revenuecat/purchases/kmp/Purchases.ios.kt # either/api/either.klib.api # either/src/commonMain/kotlin/com/revenuecat/purchases/kmp/either/Either.kt # models/api/models.api # models/api/models.klib.api # result/api/result.klib.api # result/src/commonMain/kotlin/com/revenuecat/purchases/kmp/result/Result.kt
# Conflicts: # apiTester/src/commonMain/kotlin/com/revenuecat/purchases/kmp/apitester/PaywallListenerAPI.kt # composeApp/src/commonMain/kotlin/com/revenuecat/purchases/kmp/sample/MainScreen.kt # composeApp/src/commonMain/kotlin/com/revenuecat/purchases/kmp/sample/rememberLoggingPaywallListener.kt # core/api/core.klib.api # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/MovedModels.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/Purchases.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/ktx/Coroutines.kt # core/src/iosMain/kotlin/com/revenuecat/purchases/kmp/Purchases.ios.kt # either/api/either.klib.api # either/src/commonMain/kotlin/com/revenuecat/purchases/kmp/either/Either.kt # models/api/models.api # models/api/models.klib.api # result/api/result.klib.api # result/src/commonMain/kotlin/com/revenuecat/purchases/kmp/result/Result.kt # revenuecatui/api/revenuecatui.api # revenuecatui/api/revenuecatui.klib.api # revenuecatui/src/commonMain/kotlin/com/revenuecat/purchases/kmp/ui/revenuecatui/PaywallListener.kt
# Conflicts: # apiTester/src/commonMain/kotlin/com/revenuecat/purchases/kmp/apitester/PaywallListenerAPI.kt # apiTester/src/commonMain/kotlin/com/revenuecat/purchases/kmp/apitester/PurchasesCommonAPI.kt # composeApp/src/commonMain/kotlin/com/revenuecat/purchases/kmp/sample/MainScreen.kt # composeApp/src/commonMain/kotlin/com/revenuecat/purchases/kmp/sample/rememberLoggingPaywallListener.kt # core/api/core.klib.api # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/ktx/Coroutines.kt # either/api/either.klib.api # either/src/commonMain/kotlin/com/revenuecat/purchases/kmp/either/Either.kt # models/api/models.klib.api # result/src/commonMain/kotlin/com/revenuecat/purchases/kmp/result/Result.kt # revenuecatui/api/revenuecatui.api # revenuecatui/api/revenuecatui.klib.api # revenuecatui/src/commonMain/kotlin/com/revenuecat/purchases/kmp/ui/revenuecatui/PaywallListener.kt
# Conflicts: # apiTester/src/commonMain/kotlin/com/revenuecat/purchases/kmp/apitester/PurchasesCommonAPI.kt # core/api/core.klib.api # core/src/androidMain/kotlin/com/revenuecat/purchases/kmp/Purchases.android.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/MovedModels.kt # core/src/commonMain/kotlin/com/revenuecat/purchases/kmp/Purchases.kt # core/src/iosMain/kotlin/com/revenuecat/purchases/kmp/Purchases.ios.kt # models/api/models.api # models/api/models.klib.api
This was referenced Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
modelspackage, within the:modelsmodule.:coremodule.This should be a source compatible change, but unfortunately not binary compatible.
This is one of the steps needed to address #185. This is part of a stack of PRs.