-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supports uniquePackageNames by setting the namespace for the :models module #195
Merged
Merged
Changes from all commits
Commits
Show all changes
74 commits
Select commit
Hold shift + click to select a range
3aa3115
Moves most enums to the models package.
JayShortway fedb76d
Updates the public API dump.
JayShortway 34a7a41
Moves CustomerInfo and dependencies.
JayShortway eec60d1
Updates the public API dump.
JayShortway 677e00d
Adds type aliases for EntitlementInfo enums.
JayShortway a10fb81
Moves Offerings and dependencies.
JayShortway 3163e21
Updates the public API dump.
JayShortway 5a8829b
Deprecation message says 'type' instead of 'class'.
JayShortway 6746df7
Merge branch 'models-enums' into models-customerinfo
JayShortway 19e3bf0
Deprecation message says 'type' instead of 'class'.
JayShortway cf34e8d
Merge branch 'models-customerinfo' into models-offering
JayShortway 96b9746
Moves the error types.
JayShortway f53cf2e
Updates the public API dump.
JayShortway 042688b
Deletes TestStuff.kt.
JayShortway 34a91fd
Merge branch 'models-enums' into models-customerinfo
JayShortway 7a7b6bb
Merge branch 'models-customerinfo' into models-offering
JayShortway 9b68566
Merge branch 'models-offering' into models-errors
JayShortway 07ef16d
Moves PurchasesAreCompletedBy, DangerousSettings and ReplacementMode.
JayShortway 1a389bb
Updates the public API dump.
JayShortway 4b6bf3d
Moves LogHandler and LogLevel to :core.
JayShortway f6f6e05
Updates the public API dump.
JayShortway 3abc96a
Moves PurchasesDelegate to :core.
JayShortway d1fd192
Updates the public API dump.
JayShortway a5da7ca
Enables uniquePackageNames and sets the namespace for :models.
JayShortway bf06570
Merge branch 'main' into models-enums
JayShortway 21c3ded
Merge branch 'models-enums' into models-customerinfo
JayShortway 655126f
Merge branch 'models-customerinfo' into models-offering
JayShortway debcda2
Merge branch 'models-offering' into models-errors
JayShortway a8e13e0
Merge branch 'models-errors' into models-misc
JayShortway b2a5a10
Merge branch 'models-misc' into models-loghandler
JayShortway e8cf1be
Merge branch 'models-loghandler' into models-delegate
JayShortway 692325a
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 991f3c1
Merge branch 'main' into models-enums
JayShortway 4766548
Merge branch 'models-enums' into models-customerinfo
JayShortway ee2a02f
Merge branch 'models-customerinfo' into models-offering
JayShortway adb0718
Merge branch 'models-offering' into models-errors
JayShortway a1f79ac
Merge branch 'models-errors' into models-misc
JayShortway 955602d
Merge branch 'models-misc' into models-loghandler
JayShortway 6a5a97a
Merge branch 'models-loghandler' into models-delegate
JayShortway bf047d1
Merge branch 'models-delegate' into models-unique-package-names
JayShortway f462734
Merge branch 'main' into models-customerinfo
JayShortway ef53081
Merge branch 'models-customerinfo' into models-offering
JayShortway 7577fd7
Merge branch 'models-offering' into models-errors
JayShortway c4b73b8
Merge branch 'models-errors' into models-misc
JayShortway 7709184
Merge branch 'models-misc' into models-loghandler
JayShortway 9fbb8d6
Merge branch 'models-loghandler' into models-delegate
JayShortway 2e91ffb
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 7bff723
Merge branch 'main' into models-offering
JayShortway 0376223
Merge branch 'models-offering' into models-errors
JayShortway 8662e8e
Merge branch 'models-errors' into models-misc
JayShortway 770dd6b
Merge branch 'models-misc' into models-loghandler
JayShortway bce8ed7
Merge branch 'models-loghandler' into models-delegate
JayShortway 11606a6
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 7fdb4fc
Fixes the public API dump.
JayShortway e285952
Merge branch 'models-offering' into models-errors
JayShortway 372b5df
Merge branch 'models-errors' into models-misc
JayShortway 80a8a0e
Merge branch 'models-misc' into models-loghandler
JayShortway a81e257
Merge branch 'models-loghandler' into models-delegate
JayShortway 7b74712
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 289002a
Merge branch 'main' into models-errors
JayShortway 45c0534
Merge branch 'models-errors' into models-misc
JayShortway 5526a37
Merge branch 'models-misc' into models-loghandler
JayShortway d9d0996
Merge branch 'models-loghandler' into models-delegate
JayShortway 7ce0e69
Merge branch 'models-delegate' into models-unique-package-names
JayShortway c4d9b53
Merge branch 'main' into models-misc
JayShortway a3b1ae1
Merge branch 'models-misc' into models-loghandler
JayShortway 24f34b3
Merge branch 'models-loghandler' into models-delegate
JayShortway aead3ad
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 40068ca
Merge branch 'main' into models-loghandler
JayShortway 59f8310
Merge branch 'models-loghandler' into models-delegate
JayShortway be2a3d6
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 1b598ca
Merge branch 'main' into models-delegate
JayShortway 48c6b15
Merge branch 'models-delegate' into models-unique-package-names
JayShortway 51cbaed
Merge branch 'main' into models-unique-package-names
JayShortway File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just to make sure, this wouldn't force consumers to also have this setting enabled right? (I believe it wouldn't but just to check)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh great point! I checked by publishing to mavenLocal and integrating in a new project that has
android.uniquePackageNames=false
It builds and runs fine, so I think we're good.