Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports uniquePackageNames by setting the namespace for the :models module #195

Merged
merged 74 commits into from
Sep 16, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
74 commits
Select commit Hold shift + click to select a range
3aa3115
Moves most enums to the models package.
JayShortway Sep 11, 2024
fedb76d
Updates the public API dump.
JayShortway Sep 11, 2024
34a7a41
Moves CustomerInfo and dependencies.
JayShortway Sep 11, 2024
eec60d1
Updates the public API dump.
JayShortway Sep 11, 2024
677e00d
Adds type aliases for EntitlementInfo enums.
JayShortway Sep 11, 2024
a10fb81
Moves Offerings and dependencies.
JayShortway Sep 11, 2024
3163e21
Updates the public API dump.
JayShortway Sep 11, 2024
5a8829b
Deprecation message says 'type' instead of 'class'.
JayShortway Sep 11, 2024
6746df7
Merge branch 'models-enums' into models-customerinfo
JayShortway Sep 11, 2024
19e3bf0
Deprecation message says 'type' instead of 'class'.
JayShortway Sep 11, 2024
cf34e8d
Merge branch 'models-customerinfo' into models-offering
JayShortway Sep 11, 2024
96b9746
Moves the error types.
JayShortway Sep 11, 2024
f53cf2e
Updates the public API dump.
JayShortway Sep 11, 2024
042688b
Deletes TestStuff.kt.
JayShortway Sep 11, 2024
34a91fd
Merge branch 'models-enums' into models-customerinfo
JayShortway Sep 11, 2024
7a7b6bb
Merge branch 'models-customerinfo' into models-offering
JayShortway Sep 11, 2024
9b68566
Merge branch 'models-offering' into models-errors
JayShortway Sep 11, 2024
07ef16d
Moves PurchasesAreCompletedBy, DangerousSettings and ReplacementMode.
JayShortway Sep 11, 2024
1a389bb
Updates the public API dump.
JayShortway Sep 11, 2024
4b6bf3d
Moves LogHandler and LogLevel to :core.
JayShortway Sep 11, 2024
f6f6e05
Updates the public API dump.
JayShortway Sep 11, 2024
3abc96a
Moves PurchasesDelegate to :core.
JayShortway Sep 11, 2024
d1fd192
Updates the public API dump.
JayShortway Sep 11, 2024
a5da7ca
Enables uniquePackageNames and sets the namespace for :models.
JayShortway Sep 11, 2024
bf06570
Merge branch 'main' into models-enums
JayShortway Sep 12, 2024
21c3ded
Merge branch 'models-enums' into models-customerinfo
JayShortway Sep 12, 2024
655126f
Merge branch 'models-customerinfo' into models-offering
JayShortway Sep 12, 2024
debcda2
Merge branch 'models-offering' into models-errors
JayShortway Sep 12, 2024
a8e13e0
Merge branch 'models-errors' into models-misc
JayShortway Sep 12, 2024
b2a5a10
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 12, 2024
e8cf1be
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 12, 2024
692325a
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 12, 2024
991f3c1
Merge branch 'main' into models-enums
JayShortway Sep 13, 2024
4766548
Merge branch 'models-enums' into models-customerinfo
JayShortway Sep 13, 2024
ee2a02f
Merge branch 'models-customerinfo' into models-offering
JayShortway Sep 13, 2024
adb0718
Merge branch 'models-offering' into models-errors
JayShortway Sep 13, 2024
a1f79ac
Merge branch 'models-errors' into models-misc
JayShortway Sep 13, 2024
955602d
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
6a5a97a
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
bf047d1
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
f462734
Merge branch 'main' into models-customerinfo
JayShortway Sep 13, 2024
ef53081
Merge branch 'models-customerinfo' into models-offering
JayShortway Sep 13, 2024
7577fd7
Merge branch 'models-offering' into models-errors
JayShortway Sep 13, 2024
c4b73b8
Merge branch 'models-errors' into models-misc
JayShortway Sep 13, 2024
7709184
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
9fbb8d6
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
2e91ffb
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
7bff723
Merge branch 'main' into models-offering
JayShortway Sep 13, 2024
0376223
Merge branch 'models-offering' into models-errors
JayShortway Sep 13, 2024
8662e8e
Merge branch 'models-errors' into models-misc
JayShortway Sep 13, 2024
770dd6b
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
bce8ed7
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
11606a6
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
7fdb4fc
Fixes the public API dump.
JayShortway Sep 13, 2024
e285952
Merge branch 'models-offering' into models-errors
JayShortway Sep 13, 2024
372b5df
Merge branch 'models-errors' into models-misc
JayShortway Sep 13, 2024
80a8a0e
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
a81e257
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
7b74712
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
289002a
Merge branch 'main' into models-errors
JayShortway Sep 13, 2024
45c0534
Merge branch 'models-errors' into models-misc
JayShortway Sep 13, 2024
5526a37
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
d9d0996
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
7ce0e69
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
c4d9b53
Merge branch 'main' into models-misc
JayShortway Sep 13, 2024
a3b1ae1
Merge branch 'models-misc' into models-loghandler
JayShortway Sep 13, 2024
24f34b3
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
aead3ad
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
40068ca
Merge branch 'main' into models-loghandler
JayShortway Sep 13, 2024
59f8310
Merge branch 'models-loghandler' into models-delegate
JayShortway Sep 13, 2024
be2a3d6
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
1b598ca
Merge branch 'main' into models-delegate
JayShortway Sep 13, 2024
48c6b15
Merge branch 'models-delegate' into models-unique-package-names
JayShortway Sep 13, 2024
51cbaed
Merge branch 'main' into models-unique-package-names
JayShortway Sep 16, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -9,3 +9,5 @@ kotlin.code.style=official
#Android
android.useAndroidX=true
android.nonTransitiveRClass=true
# Enabled to avoid regressions of #185.
android.uniquePackageNames=true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to make sure, this wouldn't force consumers to also have this setting enabled right? (I believe it wouldn't but just to check)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh great point! I checked by publishing to mavenLocal and integrating in a new project that has

android.uniquePackageNames=false

It builds and runs fine, so I think we're good.

2 changes: 1 addition & 1 deletion models/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,5 +22,5 @@ kotlin {
}

android {
namespace = "com.revenuecat.purchases.kmp"
namespace = "com.revenuecat.purchases.kmp.models"
}