Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds actionlint to lint GitHub Actions workflows #227

Merged
merged 8 commits into from
Sep 30, 2024
Merged

Conversation

JayShortway
Copy link
Member

As the title says. Needed, as GitHub doesn't surface errors, and I find myself going back and forth to https://rhysd.github.io/actionlint/ to fix. So I figured it's better to catch these automatically before they're committed.

@JayShortway JayShortway marked this pull request as ready for review September 30, 2024 07:29
@JayShortway JayShortway requested a review from a team September 30, 2024 07:29
Copy link
Contributor

@tonidero tonidero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting. I guess it will still let you push, but will just give an error right? In any case, this seems useful 👍

@JayShortway
Copy link
Member Author

@tonidero Yeah exactly. I didn't add it to the required checks, because I made it to only run when the GitHub Actions workflows actually change. If we want it to always run, we can add it to the required checks.

@JayShortway JayShortway merged commit 60191bd into main Sep 30, 2024
12 checks passed
@JayShortway JayShortway deleted the action-lint branch September 30, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants