Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unit tests #275

Open
wants to merge 14 commits into
base: dev-v1.11.7
Choose a base branch
from
Open

fix unit tests #275

wants to merge 14 commits into from

Conversation

samussiah
Copy link
Contributor

Issues

Closes #274

@samussiah samussiah added this to the v1.11.7 milestone Jan 12, 2020
Copy link
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samussiah This might be fine, but I was confused about the purpose of testNew.js and why sortTable was removed and createTable added

@samussiah
Copy link
Contributor Author

@pburnsdata testNew is only for trying out new unit tests. It's not actually part of the test suite.

@pburnsdata
Copy link
Contributor

pburnsdata commented Feb 7, 2020

@samussiah You can't lie to me spencer - I know what's really going on in the test suite

Copy link
Contributor

@pburnsdata pburnsdata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TESTASTIC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants