Preload git completions #296
Conversation
Modern bash completion uses a delayed completion loader so that completions for commands that are never used are not loaded. This breaks vcsh git completions if no completion for git has been performed yet. To resolve this, use the git completion load function to get the completion spec for git loaded if it is not already present.
There was a problem hiding this comment.
Thanks for the contribution. I'll assume this works as intended on bash, I'm on zsh and I'm not sure my Bash installation isn't foobared with the recent experiments I was doing.
The Editor Config stuff is duplicated by #288 which both shuffled files around and adds this config, but I guess I can sort out the merge conflict there when it happens, it's perfectly reasonable to include it here while there is activity editing the file.
There was a problem hiding this comment.
The only caveat is if you do include the Editor Config setup it does need to pass the lint tests. In my PR I resolve this by just joining that offending line into one long line instead of splitting it and having to worry about indentation. You could either resolve this the same way or drop the editor config commit, I don't care which way it goes.
jamesd
force-pushed
the
preload-git-completions
branch
from
43d5585 to
79d8b8b
Compare
jamesd
force-pushed
the
preload-git-completions
branch
from
79d8b8b to
4661cc9
Compare
Two commits: