-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add config for navigation icon #58
Conversation
Added resource Icon to config
Added getNavigationIcon from config
added 'navigation_icon' => 'heroicon-o-envelope', to config
PR Summary 📝
|
Hi Tieme, The tests are failing, could you fix? Many thanks! |
The configuration file 'filament-email.php' was updated to remove the hardcoded navigation icon. In 'EmailResource.php', implement a fallback to 'heroicon-o-envelope' if no icon is set. This solution provides flexibility to set the navigation icon from the configuration file while ensuring there's a default icon if none is specified.
Ho @RickDBCN I have changed the config. Can you check the changes please? Thanks |
The 'icon' property was added to the 'filament-email' configuration while 'navigation_icon' was removed from the configuration and README file. The reference to 'navigation_icon' was also updated to 'resource.icon' in EmailResource class to reflect these changes.
i was to quick with the pull request. |
Hi,
I want to have this resource as subnavigation without any icons.
My top navigation has a icon, because that is not in the config i added it.