Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling of scheduled prune #62

Merged

Conversation

ryanldy
Copy link
Contributor

@ryanldy ryanldy commented May 22, 2024

Details

This allows us to disable the scheduled command model:prune introduced by this package.

This is needed for cases where we want to add a ->doNotMonitor() (from spatie/laravel-schedule-monitor) to the scheduled command. With this, we will set the config to 'prune_enabled' => false then add the scheduled command model:prune to our own Kernel.php with ->doNotMonitor().

Copy link

what-the-diff bot commented May 22, 2024

PR Summary 🚀

  • Added feature to control email pruning 🌳
    We have introduced a new 'switch' in the filament-email.php configuration file. This switch, called prune_enabled, allows you to decide whether or not a specific cleaning up process (pruning) should take place in managing your emails. When set to true, the pruning will happen.

  • Conditional execution of code added 💻🧐
    We've made improvements in a file known as FilamentEmailServiceProvider.php. Now, a particular part of its code will only run if email pruning is enabled (prune_enabled is true). This means the system works smarter, not harder—only doing tasks that are necessary based on your configuration. 🧠✨

So, double-check your settings if you want your unused emails to be trimmed, making sure that prune_enabled is set to true. Keep your project clean and efficient! 😄👍

@marcogermani87 marcogermani87 self-assigned this May 22, 2024
@marcogermani87 marcogermani87 merged commit 3249d0c into RickDBCN:main May 27, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants