Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow custom storage disk & config for attachment storage #65

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

cooljet84
Copy link
Contributor

  • Added config option to set the storage disk (defaults to
  • Added config option to disable the attachment storage

Copy link

what-the-diff bot commented Jun 18, 2024

PR Summary 😃

This PR presents several significant changes mainly aiming to improve how email attachments are handled and stored in our system, as well as correcting some formatting issues. Here's a simplified overview:

  • Improved Email Attachment Storage

    • Let's start with the good stuff, we now have advanced configuration options for your email attachments in config/filament-email.php 🎉
      • You can choose where the attachments are saved using 'attachments_disk' => 'local' 🗄️
      • You can decide whether to store these attachments or not with 'store_attachments' => true 💾
  • Fixed Formatting in Email Resource

    • Inside src/Filament/Resources/EmailResource.php, we've also fixed some formatting issues. There's nothing worse than a messy-looking email, right? 😅
  • Enhanced Attachment Download

    • In src/Filament/Resources/EmailResource/Pages/ViewEmail.php, we've now made sure that before the system tries to download an attachment, it verifies whether the file exists and is located in the correctly configured disk 💽
  • Smarter Email Logger

    • Inside our faithful src/Listeners/FilamentEmailLogger.php, we've made some significant improvements 👍
      • The system is now smarter 🧠! It checks whether to store attachments based on your configured preference 🤓
      • We've also optimized the way attachments and raw email messages are saved 📝
      • Lastly, we've improved how recipient information is formatted, making it easier to understand who the email was sent to 😊

Look forward to these fantastic updates! 🚀

@RickDBCN
Copy link
Owner

Looks good to me. Thank you! :)

@RickDBCN RickDBCN merged commit 39940eb into RickDBCN:main Jun 18, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants