Remove unnecessary string creations from OpenApiDocumentMiddleware #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pr |
lahma
pushed a commit
to lahma/NSwag
that referenced
this pull request
Jan 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time methods like
string.Trim()orstring.ToLowerInvariant()are invoked on an instance of astring, an newstringinstance is created.Being a middleware,
OpenApiDocumentMiddlewareis on the hot path of every request.This PR removes those string creations from
OpenApiDocumentMiddleware.To keep the same logic as before, `string.AsSpan()´ could be used, but that doesn't work as well on .NET Framework as in .NET, performance-wise.