Fix template and test bugs from PR #4541 #4570
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulomorgado LGTM, thanks for the quick fixes! |
MaximeMorin-Devolutions
approved these changes
Nov 5, 2023
ramonsmits
reviewed
Nov 8, 2023
| BaseUrl = "{{ BaseUrl }}"; | ||
| {% endif -%} |
There was a problem hiding this comment.
Something seems of with BaseUrl, the property isn't assigned due to this when run with NSwagStudio 13.20.0.0.
There was a problem hiding this comment.
Are you replacing NSwagStudio 13.20.0.0 templates with this one?
Can you share a simple repro?
|
Is this ready to merge and will fix the problem? What about the open comment? |
As far as I could assert from the tests, yes! I have more coming up, but I want to keep them bite sized. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about that everyone.
@MaximeMorin-Devolutions, can you check the changes and propose changes for anything else you found?