Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Scale fix #27

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

howmanysmall
Copy link
Contributor

Also changed to RenderStepped because that is what Gui animations should use.

@Validark
Copy link
Member

Validark commented Dec 7, 2018

Why do you want to change from Heartbeat to RenderStepped?

@howmanysmall
Copy link
Contributor Author

RenderStepped should be used for anything on the client, such as movement or interfaces.

@Validark
Copy link
Member

Why would you need to update a GUI faster than their framerate? It wouldn't even get to render the unnecessary frames you would do the calculations for.

@Validark
Copy link
Member

The Offset of the EndSize is not taken into account in this implementation.

@Validark
Copy link
Member

I would like a source that says RenderStepped should be used for Gui animations. Heartbeat will fire every frame, which will only make a difference if they are running at less than 60fps. If they are running at less than 60fps, it will render the animations slower

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants