Fix text render on canvas copy SVG/PNG (#157)

* add fill, remove stroke * 1.10.16
RoamJS · Sep 23, 2023 · 2a90d1e · 2a90d1e
1 parent 1df786d
commit 2a90d1e
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "query-builder",
-  "version": "1.10.15",
+  "version": "1.10.16",
   "description": "Introduces new user interfaces for building queries in Roam",
   "main": "./build/main.js",
   "author": {

diff --git a/src/components/TldrawCanvas.tsx b/src/components/TldrawCanvas.tsx
@@ -774,7 +774,10 @@ class DiscourseNodeUtil extends TLBoxUtil<DiscourseNodeShape> {
     rect.setAttribute("ry", "16");
     g.appendChild(rect);
 
-    // TODO: Look at ./node_modules/@tldraw/tldraw/node_modules/@tldraw/editor/dist/cjs/lib/app/shapeutils/TLTextUtil/TLTextUtil.js toSvg method
+    // TODO: Look at Look at TLTextUtil / TLGeoUtil toSvg methods
+    // ./node_modules/@tldraw/tldraw/node_modules/@tldraw/editor/dist/cjs/lib/app/shapeutils/
+    // /TLTextUtil/TLTextUtil.js
+    // /TLGeoUtil/TLGeoUtil.js
     // for non-manual way to implement this
     const text = document.createElementNS("http://www.w3.org/2000/svg", "text");
     const padding = Number(DEFAULT_STYLE_PROPS.padding.replace("px", ""));
@@ -787,8 +790,8 @@ class DiscourseNodeUtil extends TLBoxUtil<DiscourseNodeShape> {
     text.setAttribute("font-family", "sans-serif");
     text.setAttribute("font-size", DEFAULT_STYLE_PROPS.fontSize + "px");
     text.setAttribute("font-weight", DEFAULT_STYLE_PROPS.fontWeight);
-    text.setAttribute("stroke", textColor);
-    text.setAttribute("stroke-width", "1");
+    text.setAttribute("fill", textColor);
+    text.setAttribute("stroke", "none");
     const words = shape.props.title.split(/\s/g);
     let line = "";
     let lineCount = 0;