Canvas add/edit node dialog fix (#136)

* bring back node edit, add close dialog onSuccess * 1.10.6
RoamJS · Aug 8, 2023 · 49028c0 · 49028c0
1 parent 63db095
commit 49028c0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 6 deletions.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "query-builder",
-  "version": "1.10.5",
+  "version": "1.10.6",
   "description": "Introduces new user interfaces for building queries in Roam",
   "main": "./build/main.js",
   "author": {

diff --git a/src/components/TldrawCanvas.tsx b/src/components/TldrawCanvas.tsx
@@ -631,9 +631,9 @@ class DiscourseNodeUtil extends TLBoxUtil<DiscourseNodeShape> {
       [this.app, shape.id]
     );
     const [isLabelEditOpen, setIsEditLabelOpen] = useState(false);
-    // useEffect(() => {
-    //   if (isEditing) setIsEditLabelOpen(true);
-    // }, [isEditing, setIsEditLabelOpen]);
+    useEffect(() => {
+      if (isEditing) setIsEditLabelOpen(true);
+    }, [isEditing, setIsEditLabelOpen]);
     const contentRef = useRef<HTMLDivElement>(null);
     const [loaded, setLoaded] = useState("");
     useEffect(() => {
@@ -734,6 +734,8 @@ class DiscourseNodeUtil extends TLBoxUtil<DiscourseNodeShape> {
                 w,
                 h,
               });
+              setIsEditLabelOpen(false);
+              this.app.setEditingId(null);
               await this.createExistingRelations(shape, {
                 allRecords,
                 relationIds,