handle attribute URLs (#296)

RoamJS · Dec 31, 2024 · 63c609c · 63c609c
1 parent ad962dd
commit 63c609c
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/src/components/ResultsTable.tsx b/src/components/ResultsTable.tsx
@@ -307,7 +307,7 @@ const ResultRow = ({
                 <a
                   className={"rm-page-ref"}
                   data-link-title={getPageTitleByPageUid(uid) || ""}
-                  href={getRoamUrl(uid)}
+                  href={(r[`${key}-url`] as string) || getRoamUrl(uid)}
                   onMouseDown={(e) => {
                     if (e.shiftKey) {
                       openBlockInSidebar(uid);

diff --git a/src/utils/predefinedSelections.ts b/src/utils/predefinedSelections.ts
@@ -117,6 +117,15 @@ const formatDate = ({
 const flatten = (blocks: PullBlock[] = []): PullBlock[] =>
   blocks.flatMap((b) => [b, ...flatten(b[":block/children"])]);
 
+const isValidUrl = (value: string): boolean => {
+  try {
+    new URL(value);
+    return true;
+  } catch {
+    return false;
+  }
+};
+
 const getBlockAttribute = (key: string, r: PullBlock) => {
   const blocks = flatten(
     window.roamAlphaAPI.pull(
@@ -127,9 +136,12 @@ const getBlockAttribute = (key: string, r: PullBlock) => {
   const block = blocks.find((blk) =>
     (blk[":block/string"] || "").startsWith(key + "::")
   );
+  const value = (block?.[":block/string"] || "").slice(key.length + 2).trim();
+
   return {
-    "": (block?.[":block/string"] || "").slice(key.length + 2).trim(),
+    "": value,
     "-uid": block?.[":block/uid"] || "",
+    ...(isValidUrl(value) && { "-url": value }),
   };
 };