Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(locale): don't try dynamically importing the default locale #2098

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

anehx
Copy link
Contributor

@anehx anehx commented Mar 14, 2024

If "en" is passed as locale to the <EmberFlatpickr /> component, the addon will try importing a file flatpickr/dist/l10n/en.js which does not exist as English is the default language that is included in the core and doesn't need to be imported additionally.

If `"en"` is passed as locale to the `<EmberFlatpickr />` component, the
addon will try importing a file `flatpickr/dist/l10n/en.js` which does
not exist as English is the default language that is included in the
core and doesn't need to be imported additionally.
@RobbieTheWagner
Copy link
Owner

Ah, good catch, thank you @anehx!

@anehx
Copy link
Contributor Author

anehx commented Mar 18, 2024

@RobbieTheWagner Can we get this merged and released? I have a few projects that currently need a workaround that can be removed with this released.

@RobbieTheWagner RobbieTheWagner merged commit adb4195 into RobbieTheWagner:main Mar 18, 2024
10 checks passed
@anehx anehx deleted the locale-fix branch March 18, 2024 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants