Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Future: Drop Node 18 #2063

Draft
wants to merge 27 commits into
base: make-v21
Choose a base branch
from
Draft

Future: Drop Node 18 #2063

wants to merge 27 commits into from

Conversation

RobinTail
Copy link
Owner

@RobinTail RobinTail commented Sep 29, 2024 •
edited
Loading

Planned for next major after 30.04.2025
https://endoflife.date/nodejs

Including refactoring time units formatting using Intl built-ins.

The part of using Intl for profiling can be cherry-picked if the following issue fixed: can not be fixed in Node 18:

https://github.com/nodejs/node/issues/55833

@RobinTail RobinTail added CI/CD breaking Backward incompatible changes labels Sep 29, 2024
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Sep 29, 2024 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 3cd7d46 on drop-node18
into 6e868fa on make-v21.

@RobinTail RobinTail added the dependencies Pull requests that update a dependency file label Sep 29, 2024
@RobinTail RobinTail added the coverage Additional tests label Sep 29, 2024
@RobinTail RobinTail added this to the v21 milestone Sep 29, 2024
@RobinTail RobinTail added enhancement New feature or request refactoring The better way to achieve the same result labels Sep 29, 2024
@RobinTail RobinTail added the documentation Improvements or additions to documentation label Sep 29, 2024
RobinTail
RobinTail commented Sep 29, 2024
View reviewed changes
Copy link
Owner Author

@RobinTail RobinTail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed

RobinTail
RobinTail commented Oct 7, 2024
View reviewed changes
src/logger-helpers.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail changed the title Future: Drop Node 18 Next: Drop Node 18 Oct 8, 2024
@RobinTail RobinTail mentioned this pull request Oct 8, 2024
Open
@RobinTail RobinTail changed the base branch from master to make-v21 October 8, 2024 20:09
@RobinTail RobinTail marked this pull request as ready for review October 8, 2024 20:09
@RobinTail RobinTail changed the title Next: Drop Node 18 Drop Node 18 Oct 8, 2024
@RobinTail RobinTail marked this pull request as draft October 8, 2024 20:13
@RobinTail RobinTail changed the title Drop Node 18 Future: Drop Node 18 Oct 8, 2024
RobinTail
RobinTail commented Nov 6, 2024
View reviewed changes
src/builtin-logger.ts Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
breaking Backward incompatible changes CI/CD coverage Additional tests dependencies Pull requests that update a dependency file documentation Improvements or additions to documentation enhancement New feature or request refactoring The better way to achieve the same result
Projects
None yet
Milestone
v21
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail