fix: INSTALL.md can now be followed to install grSim on macOS. #179
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
grSim cannot be installed currently on macOS by following INSTALL.md
#176
Description of the Change
removed legacy protocolbuffers cmake api usage, now grSim can build using
brew install protobuf@21
, still doesn't build with latest because of a problem with abseil, protobuf 21 doesn't use abseil. And updated INSTALL.mdAlternate Designs
tried to follow as closely the current CMakeLists.txt structures, could have updated them to build a separate object as the protocolbuffers example usage suggests https://github.com/protocolbuffers/protobuf/blob/main/docs/cmake_protobuf_generate.md
Possible Drawbacks
Verification Process
need to be tested on other OS, works on macOS sonoma with protobuf@21 installed via brew.
Release Notes
FIX - INSTALL.md can now be followed to install grSim on macOS.