Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unsaved Change Warning on UpdateUserProfile - #1060 #4956

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Unsaved Change Warning on UpdateUserProfile - #1060 #4956

wants to merge 5 commits into from

Conversation

jvogt23
Copy link
Contributor

@jvogt23 jvogt23 commented Dec 9, 2024

Uses vanilla JS and should be replaced with navigation guards if we switch to vue router. Solves #1060

@jvogt23
Added unsaved changes warning using vanilla JS. Should be switched wi…
2be58ae 
…th navigation guards if Vue Router is added to this project.
@jvogt23 jvogt23 requested a review from evan10s December 9, 2024 03:07
@jvogt23 jvogt23 linked an issue Dec 9, 2024 that may be closed by this pull request
Profile page should warn when leaving with unsaved changes #1060
Open
@evan10s
Copy link
Member

evan10s commented Dec 12, 2024 •
edited
Loading

we should deploy to apiary-test to test before merging, have you done that before?

@jvogt23
Copy link
Contributor Author

jvogt23 commented Dec 12, 2024

we should deploy to apiary-test to test before merging, have you done that before?

I have not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@evan10s evan10s evan10s left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Profile page should warn when leaving with unsaved changes
2 participants
@jvogt23 @evan10s