Skip to content

Commit

Permalink
Merge pull request #253 from traversaro/addzenoh
Browse files Browse the repository at this point in the history
 Add rmw_zenoh_cpp and de-vendor zenoh_cpp_vendor
  • Loading branch information
Tobias-Fischer authored Jan 23, 2025
2 parents ff88d81 + 1c18078 commit fb9736d
Show file tree
Hide file tree
Showing 9 changed files with 69 additions and 1 deletion.
5 changes: 5 additions & 0 deletions conda_build_config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -41,3 +41,8 @@ cxx_compiler:
cxx_compiler_version: # [unix]
- 13 # [linux]
- 18 # [osx]

libzenohc:
- 1.1.1
libzenohcxx:
- 1.1.1
6 changes: 5 additions & 1 deletion patch/dependencies.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -179,4 +179,8 @@ rosx_introspection:
octomap_ros:
add_host: ["octomap"]
octomap_rviz_plugins:
add_host: ["octomap"]
add_host: ["octomap"]
zenoh_cpp_vendor:
add_host: ["libzenohc", "libzenohcxx"]
rmw_zenoh_cpp:
add_host: ["libzenohc", "libzenohcxx"]
42 changes: 42 additions & 0 deletions patch/ros-humble-zenoh-cpp-vendor.patch
Original file line number Diff line number Diff line change
@@ -0,0 +1,42 @@
diff --git a/zenoh_cpp_vendor/CMakeLists.txt b/zenoh_cpp_vendor/CMakeLists.txt
index 2d3ae046..de971841 100644
--- a/zenoh_cpp_vendor/CMakeLists.txt
+++ b/zenoh_cpp_vendor/CMakeLists.txt
@@ -10,35 +10,10 @@ endif()
find_package(ament_cmake REQUIRED)
find_package(ament_cmake_vendor_package REQUIRED)

-# Disable default features and enable only the most useful ones. This reduces build time and footprint.
-# For a complete list of features see: https://github.com/eclipse-zenoh/zenoh/blob/main/zenoh/Cargo.toml
-# Note: We separate the two args needed for cargo with "$<SEMICOLON>" and not ";" as the
-# latter is a list separater in cmake and hence the string will be split into two
-# when expanded.
-set(ZENOHC_CARGO_FLAGS "--no-default-features$<SEMICOLON>--features=shared-memory zenoh/transport_compression zenoh/transport_tcp zenoh/transport_tls")
-
-ament_vendor(zenoh_c_vendor
- VCS_URL https://github.com/eclipse-zenoh/zenoh-c.git
- VCS_VERSION 57d5e4d31d9b38fef34d7bcad3d3e54869c4ce73
- CMAKE_ARGS
- "-DZENOHC_CARGO_FLAGS=${ZENOHC_CARGO_FLAGS}"
- "-DZENOHC_BUILD_WITH_UNSTABLE_API=TRUE"
- "-DZENOHC_CUSTOM_TARGET=${ZENOHC_CUSTOM_TARGET}"
-)
-
+find_package(zenohc REQUIRED)
ament_export_dependencies(zenohc)

-# Set VCS_VERSION to include latest changes from zenoh-c to benefit from :
-# - https://github.com/eclipse-zenoh/zenoh-cpp/pull/342 (Fix include what you use)
-ament_vendor(zenoh_cpp_vendor
- VCS_URL https://github.com/eclipse-zenoh/zenoh-cpp
- VCS_VERSION 964b64dc8b935a43147287199e7bb12da7b141e6
- CMAKE_ARGS
- -DZENOHCXX_ZENOHC=OFF
-)
-
-externalproject_add_stepdependencies(zenoh_cpp_vendor configure zenoh_c_vendor)
-
+find_package(zenohcxx REQUIRED)
ament_export_dependencies(zenohcxx)

ament_package()
2 changes: 2 additions & 0 deletions robostack.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,8 @@ cartographer:
robostack: [cartographer]
ca-certificates:
robostack: [ca-certificates]
cargo:
robostack: [rust]
clang-format:
robostack: [clang-format]
clang-tidy:
Expand Down
3 changes: 3 additions & 0 deletions vinca_linux_64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,9 @@ packages_select_by_deps:
# requested in https://github.com/RoboStack/ros-humble/issues/249
- twist_mux

# requested in https://github.com/RoboStack/ros-humble/issues/252
- rmw_zenoh_cpp

# ----- end of package support -----

# - rtabmap
Expand Down
3 changes: 3 additions & 0 deletions vinca_linux_aarch64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,9 @@ packages_select_by_deps:
# requested in https://github.com/RoboStack/ros-humble/issues/249
- twist_mux

# requested in https://github.com/RoboStack/ros-humble/issues/252
- rmw_zenoh_cpp

# Used to work, now needs fixes
# - rtabmap
# - webots-ros2
Expand Down
3 changes: 3 additions & 0 deletions vinca_osx.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -132,5 +132,8 @@ packages_select_by_deps:
# requested in https://github.com/RoboStack/ros-humble/issues/249
- twist_mux

# requested in https://github.com/RoboStack/ros-humble/issues/252
- rmw_zenoh_cpp

patch_dir: patch
rosdistro_snapshot: rosdistro_snapshot.yaml
3 changes: 3 additions & 0 deletions vinca_osx_arm64.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -122,5 +122,8 @@ packages_select_by_deps:
# requested in https://github.com/RoboStack/ros-humble/issues/249
- twist_mux

# requested in https://github.com/RoboStack/ros-humble/issues/252
- rmw_zenoh_cpp

patch_dir: patch
rosdistro_snapshot: rosdistro_snapshot.yaml
3 changes: 3 additions & 0 deletions vinca_win.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -246,5 +246,8 @@ packages_select_by_deps:
# requested in https://github.com/RoboStack/ros-humble/issues/249
- twist_mux

# requested in https://github.com/RoboStack/ros-humble/issues/252
- rmw_zenoh_cpp

patch_dir: patch
rosdistro_snapshot: rosdistro_snapshot.yaml

0 comments on commit fb9736d

Please sign in to comment.