Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add lanelet2 #242

Merged
merged 10 commits into from
Jan 14, 2025
Merged

feat: add lanelet2 #242

merged 10 commits into from
Jan 14, 2025

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Jan 10, 2025

  • as title

Signed-off-by: wep21 <[email protected]>
@wep21
Copy link
Contributor Author

wep21 commented Jan 10, 2025

@Tobias-Fischer need approve to run ci?

@Tobias-Fischer
Copy link
Contributor

@wep21 - I fixed the errors on MacOS+Linux. However, I do not have the capacity to fix the Windows issues. Please either add relevant patches yourself if you are interested, or remove the addition of lanelet2 on Windows.

/cc @traversaro as our Windows expert.

@wep21
Copy link
Contributor Author

wep21 commented Jan 11, 2025

@Tobias-Fischer Thanks for the fix. I'm trying to fix the error on windows. Is there any way to trigger ci again?

@Tobias-Fischer
Copy link
Contributor

Seems like this didn’t work @wep21 - can you try a local build first? It’s as easy as cloning the repo and running “pixi run build”

Signed-off-by: wep21 <[email protected]>
@wep21
Copy link
Contributor Author

wep21 commented Jan 11, 2025

Currently, I don't have windows environment, so I'll debug with my fork repository first.

wep21 added 4 commits January 11, 2025 22:51
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
@wep21
Copy link
Contributor Author

wep21 commented Jan 13, 2025

@Tobias-Fischer @traversaro I've fixed the windows build error. I appreciate if you could review the patches. https://github.com/wep21/ros-humble/actions/runs/12750363858/job/35534922572?pr=3

Copy link
Contributor

@Tobias-Fischer Tobias-Fischer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - @traversaro do you want to take a look as well?

@traversaro
Copy link
Member

Seems great! @wep21 do you think it could make sense to also propose these changes upstream? It may be more work in the short term, but in the long run it removes the need to manually maintain the patches, and make the fixes available also for non-robostack users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants