-
-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add lanelet2 #242
feat: add lanelet2 #242
Conversation
wep21
commented
Jan 10, 2025
- as title
Signed-off-by: wep21 <[email protected]>
@Tobias-Fischer need approve to run ci? |
@wep21 - I fixed the errors on MacOS+Linux. However, I do not have the capacity to fix the Windows issues. Please either add relevant patches yourself if you are interested, or remove the addition of lanelet2 on Windows. /cc @traversaro as our Windows expert. |
Signed-off-by: wep21 <[email protected]>
@Tobias-Fischer Thanks for the fix. I'm trying to fix the error on windows. Is there any way to trigger ci again? |
Seems like this didn’t work @wep21 - can you try a local build first? It’s as easy as cloning the repo and running “pixi run build” |
Signed-off-by: wep21 <[email protected]>
Currently, I don't have windows environment, so I'll debug with my fork repository first. |
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
@Tobias-Fischer @traversaro I've fixed the windows build error. I appreciate if you could review the patches. https://github.com/wep21/ros-humble/actions/runs/12750363858/job/35534922572?pr=3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - @traversaro do you want to take a look as well?
Seems great! @wep21 do you think it could make sense to also propose these changes upstream? It may be more work in the short term, but in the long run it removes the need to manually maintain the patches, and make the fixes available also for non-robostack users. |