Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add apt hold for shim-signed on Jammy #289

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add apt hold for shim-signed on Jammy #289

wants to merge 1 commit into from

Conversation

BetsyMcPhail
Copy link
Contributor

@BetsyMcPhail BetsyMcPhail commented Sep 3, 2024 •
edited by jwnimmer-tri
Loading

This change is Reviewable

BetsyMcPhail
BetsyMcPhail commented Sep 3, 2024
View reviewed changes
Copy link
Contributor Author

@BetsyMcPhail BetsyMcPhail left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@mwoehlke-kitware for review. I'm undecided if this is the best solution. I updated the unprovisioned Jammy AMI with the change below and then added it to this script so we don't lose it if the AMI gets recreated from scratch. The other option would be to leave the AMI alone and update https://github.com/RobotLocomotion/drake-ci/blob/main/setup/ubuntu/install_prereqs, where some similar holds already exist.... Do you have any preference?

Reviewable status: 0 of 1 files reviewed, all discussions resolved (waiting on @mwoehlke-kitware)

mwoehlke-kitware
mwoehlke-kitware reviewed Sep 5, 2024
View reviewed changes
Copy link
Contributor

@mwoehlke-kitware mwoehlke-kitware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:, after looking into what this package is, it looks like it should be pretty harmless to keep it at the same version as the unprovisioned image. Can't say I'm aware of any particular logic for what should go in ami_init_script vs. install_prereqs, so... 🤷

Reviewable status: 0 of 1 files reviewed, all discussions resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mwoehlke-kitware mwoehlke-kitware mwoehlke-kitware left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@mwoehlke-kitware mwoehlke-kitware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BetsyMcPhail @mwoehlke-kitware