Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade gtest to fix breaking bazel change #204

Conversation

sloretz
Copy link
Collaborator

@sloretz sloretz commented Dec 29, 2022

Noticed in #189

Bazel can no longer build the version of gtest specified by drake_ros_core, drake_ros_viz, and drake_ros_tf2.

ERROR: /home/runner/.cache/bazel/_bazel_runner/028206ac998ad78d07e8acc492e5bd46/external/bazel_tools/platforms/BUILD:89:6: in alias rule @bazel_tools//platforms:windows: Constraints from @bazel_tools//platforms have been removed. Please use constraints from @platforms repository embedded in Bazel, or preferably declare dependency on https://github.com/bazelbuild/platforms. See https://github.com/bazelbuild/bazel/issues/8622 for details.
ERROR: /home/runner/.cache/bazel/_bazel_runner/028206ac998ad78d07e8acc492e5bd46/external/bazel_tools/platforms/BUILD:89:6: Analysis of target '@bazel_tools//platforms:windows' failed
INFO: Repository remote_coverage_tools instantiated at:
  /DEFAULT.WORKSPACE.SUFFIX:4:6: in <toplevel>
  /home/runner/.cache/bazel/_bazel_runner/028206ac998ad78d07e8acc492e5bd46/external/bazel_tools/tools/build_defs/repo/utils.bzl:233:18: in maybe
Repository rule http_archive defined at:
  /home/runner/.cache/bazel/_bazel_runner/028206ac998ad78d07e8acc492e5bd46/external/bazel_tools/tools/build_defs/repo/http.bzl:372:31: in <toplevel>
ERROR: /home/runner/.cache/bazel/_bazel_runner/028206ac998ad78d07e8acc492e5bd46/external/com_google_googletest/BUILD.bazel:116:11: errors encountered resolving select() keys for @com_google_googletest//:gtest_main

https://github.com/RobotLocomotion/drake-ros/actions/runs/3802593789/jobs/6468228156

There's something unusual in that the breaking change was supposed to be in bazel 6, but the job in question says it installed bazel 5.3.1.

2022-12-29 19:15:28 (81.5 MB/s) - ‘/tmp/bazel_5.3.1-amd64.deb’ saved [48640608/48640608]

/tmp/bazel_5.3.1-amd64.deb: OK

Selecting previously unselected package bazel.
(Reading database ... 273581 files and directories currently installed.)
Preparing to unpack /tmp/bazel_5.3.1-amd64.deb ...
Unpacking bazel (5.3.1) ...
Setting up bazel (5.3.1) ...
install_prereqs: success

Maybe CI is also installing bazel 6.0 somehow?


This change is Reviewable

Copy link
Collaborator Author

@sloretz sloretz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+@EricCousineau-TRI for review please!

Reviewable status: 0 of 3 files reviewed, all discussions resolved (waiting on @EricCousineau-TRI)

Copy link
Collaborator

@EricCousineau-TRI EricCousineau-TRI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bit concerned as well about what the true root cause is, but onwards! :lgtm_strong:

Reviewed 3 of 3 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @sloretz)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants