Cleaned up Docker pipelines #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evan-palmer
commented
Oct 12, 2023
|
@mergify backport iron |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Cleaned up Dockerfile and added new user entrypoints * Fixed robot pipeline to support building for arm64 * Updated devcontainer configurations to use latest changes * Testing pipelines * Removed testing branch from pipelines * Precommit * Resolved pr comments (cherry picked from commit 11807c8) # Conflicts: # .devcontainer/nouveau/devcontainer.json # .devcontainer/nvidia/devcontainer.json # .github/ISSUE_TEMPLATE/config.yaml # .github/workflows/ci.yaml
|
@mergify backport humble |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
* Cleaned up Dockerfile and added new user entrypoints * Fixed robot pipeline to support building for arm64 * Updated devcontainer configurations to use latest changes * Testing pipelines * Removed testing branch from pipelines * Precommit * Resolved pr comments (cherry picked from commit 11807c8) # Conflicts: # .devcontainer/nouveau/devcontainer.json # .devcontainer/nvidia/devcontainer.json # .github/ISSUE_TEMPLATE/config.yaml # .github/workflows/ci.yaml
evan-palmer
added a commit
that referenced
this pull request
Oct 12, 2023
* Cleaned up Docker pipelines (#121) * Cleaned up Dockerfile and added new user entrypoints * Fixed robot pipeline to support building for arm64 * Updated devcontainer configurations to use latest changes * Testing pipelines * Removed testing branch from pipelines * Precommit * Resolved pr comments (cherry picked from commit 11807c8) # Conflicts: # .devcontainer/nouveau/devcontainer.json # .devcontainer/nvidia/devcontainer.json # .github/ISSUE_TEMPLATE/config.yaml # .github/workflows/ci.yaml * Fixed backport * Fixed config merge conflict --------- Co-authored-by: Evan Palmer <[email protected]>
evan-palmer
added a commit
that referenced
this pull request
Oct 12, 2023
* Cleaned up Docker pipelines (#121) * Cleaned up Dockerfile and added new user entrypoints * Fixed robot pipeline to support building for arm64 * Updated devcontainer configurations to use latest changes * Testing pipelines * Removed testing branch from pipelines * Precommit * Resolved pr comments (cherry picked from commit 11807c8) # Conflicts: # .devcontainer/nouveau/devcontainer.json # .devcontainer/nvidia/devcontainer.json # .github/ISSUE_TEMPLATE/config.yaml # .github/workflows/ci.yaml * Fixed humble backport * Fixed config merge conflict --------- Co-authored-by: Evan Palmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Changes Made
This PR cleans up the Dockerfile and updates the CI pipelines to support a new robot and desktop stage. The robot stage provides a minimal installation for use on a robot and is built to support the AMD64 and arm64 architectures. The desktop stage provides a complete installation that users can use to work with the project. docker-compose scripts have been added to make it easier to launch the desktop image.
Associated Issues
Testing
I've tested out the CD pipelines on both my desktop (NVIDIA drivers) and laptop (Nouveau drivers) and can confirm that the desktop image works on both. I've also tested out the updated devcontainer and that also works on both platforms.