-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate ros2_control and add user documentation (backport #162) #163
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Started migration to new controller package and ardusub interface * Replaced launch files with yaml * Started integrating new control framework * Removed old scripts and configuration files; continued ardusub manager integration * Fixed launch files and started debugging manager * Fixed mavros configuration file * Added vscode file * Working state - need to finish updates to joy package * Working state all vehicles updated * Save point before I break things * Waiting to add demos until i add documentation * Added docs * Started reintegrating demos * Cleaned up devcontainer config * Added demos and vehicle images * Added links to demo readme * Added tutorials * Cleaned up site visualizations and styling * Updated readme * Moved citation * Fixed issues in tutorials * Fixed ci * Removed codespell * Fixed spelling errors * Fixed dockerignore * Added user documentation (#160) * Added docs * Started reintegrating demos * Cleaned up devcontainer config * Added demos and vehicle images * Added links to demo readme * Added tutorials * Cleaned up site visualizations and styling * Updated readme * Moved citation * Fixed issues in tutorials * Fixed ci * Removed codespell * Fixed spelling errors * Fixed dockerignore * Testing docs cd pipeline * Fixed reference to package-lock * Added path to docs * prolly wont work but worth a shot * take 2 * Another attempt * Testing * Removed previous change * Added separate ci docs pipeline * Added fixes and switched back to rolling * Fixed dockerfile ros version * Fixed readme (cherry picked from commit 3709432) # Conflicts: # .devcontainer/nouveau/devcontainer.json # .devcontainer/nvidia/devcontainer.json # blue.repos
Cherry-pick of 3709432 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Made
This is a pretty significant PR that makes several API-breaking changes. In particular, the following breaking changes were made:
blue_dynamics
has been ported to hydrodynamics. The new project cleans up the original dynamics implementation and will also make it easier to add new features that are unrelated to Blue (e.g., parsing hydrodynamic parameters from a URDF/SDF file).blue_control
has been re-written using ros2_control and ported to auv_controllers. Controllers will now be easier to implement and are vehicle-agnostic.sitl.launch.py
,blue_joy
,blue_manager
, and the PWM passthrough handling have all been ported to ardusub_driver.ardusub_bringup
.thruster_hardware
package and is implemented as a ros2_controlhardware interface
blue_manager
now lives inardusub_manager
and has been cleaned up.blue_joy
package has becomeardusub_teleop
and now has a joystick configuration file tailored specifically toArduSub.
blue_utils
has been removed.Outside of these breaking changes, user documentation has been added with pipelines that deploy the documentation on push to main. The documentation is written using Docusaurus.
Associated Issues
Testing
Testing was done in simulation using SITL.
This is an automatic backport of pull request #162 done by [Mergify](https://mergify.com).